From afed4c8438ae8004615ab531cb0c56091e72e9db Mon Sep 17 00:00:00 2001
From: Michael Babienco <mbabienco@southern.edu>
Date: Wed, 22 Apr 2026 10:58:16 +0900
Subject: [PATCH] Always save data to internal directory

---
 TODO.txt                                           |  2 ++
 src/MayShow.Shared/Models/Settings.cs              |  1 +
 src/MayShow.Shared/ViewModels/SettingsViewModel.cs | 12 ++++++------
 src/MayShow.Shared/Views/SettingsView.axaml        |  2 +-
 4 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/TODO.txt b/TODO.txt
index 2f355f6..e2c5036 100644
--- a/TODO.txt
+++ b/TODO.txt
@@ -7,8 +7,10 @@
 
 -always save report data (file locations, title, etc.) to internal dir (might already be done?)
 -add dropdown to Add Items button to have add items from folder and remove choose working folder option (data always saved internally)
+-no more option to save data internally -> ALWAYS save report_data.json internally
 -update project title -> should update recently used data
     -this sort of works, something is wrong with the upgrade process where the UUID is not brought over properly; need to test and fix (maybe fixed already and my dataset is wrong?)
+-make backup of last generated PDF
 -iOS-specific (MAUI essentials?)
     -Take picture
     -Add pic from gallery
diff --git a/src/MayShow.Shared/Models/Settings.cs b/src/MayShow.Shared/Models/Settings.cs
index 6fc186d..1075b6a 100644
--- a/src/MayShow.Shared/Models/Settings.cs
+++ b/src/MayShow.Shared/Models/Settings.cs
@@ -217,6 +217,7 @@ class Settings : ChangeNotifier
             }
             settings.AllReportInfo = list.OrderBy(x => x.Title).ToList();
             settings.WorkingFolderToInternalFolderName = []; // clear this list; it is no longer going to be used
+            settings.SaveReportJsonDataInInternalDir = true; // this is now always true
             settings.SettingsVersion = 2;
             settings.SaveSettingsNotAsync(); // saves all data; UUIDs should be in sync if user has toggled settings
         }
diff --git a/src/MayShow.Shared/ViewModels/SettingsViewModel.cs b/src/MayShow.Shared/ViewModels/SettingsViewModel.cs
index 516e10f..abdef45 100644
--- a/src/MayShow.Shared/ViewModels/SettingsViewModel.cs
+++ b/src/MayShow.Shared/ViewModels/SettingsViewModel.cs
@@ -115,12 +115,12 @@ class SettingsViewModel: ChangeNotifier
 
     public bool SaveReportJsonDataInInternalDir
     {
-        get => _settings.SaveReportJsonDataInInternalDir;
-        set
-        {
-            _settings.SaveReportJsonDataInInternalDir = value;
-            NotifyPropertyChanged();
-        }
+        get => true; // _settings.SaveReportJsonDataInInternalDir;
+        //set
+        //{
+        //    _settings.SaveReportJsonDataInInternalDir = value;
+        //    NotifyPropertyChanged();
+        //}
     }
 
     public List<DateDisplayFormat> DateFormats
diff --git a/src/MayShow.Shared/Views/SettingsView.axaml b/src/MayShow.Shared/Views/SettingsView.axaml
index 35dd693..2881b98 100644
--- a/src/MayShow.Shared/Views/SettingsView.axaml
+++ b/src/MayShow.Shared/Views/SettingsView.axaml
@@ -72,7 +72,7 @@
                     </DataTemplate>
                 </ComboBox.ItemTemplate>
             </ComboBox>
-            <CheckBox IsChecked="{Binding SaveReportJsonDataInInternalDir}">Save report data (names, notes, etc.) in MayShow settings directory (saves in working directory by default)</CheckBox>
+            <!-- <CheckBox IsChecked="{Binding SaveReportJsonDataInInternalDir}">Save report data (names, notes, etc.) in MayShow settings directory (saves in working directory by default)</CheckBox> -->
             <Button Command="{Binding OpenSettingsDir}">
                 <TextBlock>
                     <Run Text="&#xf07c;"